-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable MySQL OIDC DB token manager test due to limited Github CI resources #36695
Disable MySQL OIDC DB token manager test due to limited Github CI resources #36695
Conversation
TBH, I'm not sure it's really necessary to test this feature with all the supported databases. Testing only with PostgreSQL would have my preference. |
There is nothing wrong with these tests. They are there because you Actual failure:
I read as: Keycloak Dev Services start Keycloak and than it can't be used and there is no failure, app keeps going on. With that said, I understand resources are tight and you know best what is possible to run and what is not. The fact is it keeps failing in CI. And I don't know how to fix it. |
Hey Michal, yeah, your tests are of good quality, but indeed, we don't need to be concerned about the portability of various reactive DB clients with respect to this feature, it is not of major concern for this extension as long as the concept is tested with a mainstream DB like Postgresql. And we have this feature tested with Oracle in Native |
May be DevService which is being closed is holding on to some resources for too long, but I'd not be worried about it when testing this extension :-) |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@gsmet This one can go in now too I believe - will def save some resources too |
This test unfortunately keeps failing, but we still have a few other DB tests in
deployment
plus an Oracle DB integration test