Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use layer 7 proxy for reactive pg client #36704

Merged

Conversation

juandiii
Copy link
Contributor

@juandiii juandiii commented Oct 25, 2023

This enables configuration of the new setUseLayer7Proxy value provided by Vert.x.

Level 7 proxies can load balance queries on several connections to the actual database. When it happens, the client can be confused by the lack of session affinity and unwanted errors can happen like ERROR: unnamed prepared statement does not exist (26000).

See more information in Using a level 7 Proxy

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 25, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@juandiii juandiii changed the title add use layer 7 proxy for reactive pg client Add use layer 7 proxy for reactive pg client Oct 25, 2023
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@quarkus-bot

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a couple of suggestions.

Is it supported by the other reactive db clients? If so, maybe we should generalize it?

@juandiii
Copy link
Contributor Author

Thanks! I added a couple of suggestions.

Is it supported by the other reactive db clients? If so, maybe we should generalize it?

HI @gsmet, only is supported for reactive PG Client.

@gsmet gsmet force-pushed the feature/reactive-pg-client-use-layer-7-proxy branch from 9cbeba1 to 21314a7 Compare October 26, 2023 12:11
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I rebased to squash the commits, thanks for the quick turnaround.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 26, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit e265e36 into quarkusio:main Oct 26, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 26, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 26, 2023
@gsmet
Copy link
Member

gsmet commented Oct 26, 2023

And merged. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants