-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ContainerRuntimeUtil.ContainerRuntime#isPodman check #37576
Fix ContainerRuntimeUtil.ContainerRuntime#isPodman check #37576
Conversation
Carelessly broke it in quarkusio#37389
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Note I didn't check against my reproducer that this fixed the problem, because I'm currently working on another branch and can't rebuild Quarkus. But I assume you did :)
It's odd that our integration tests didn't catch this though 🤔 |
They use docker, not rootless podman :/
Yes I did :) |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@zakkak This is just for my own curiosity, but does the docker test ( |
@johnmanko yes, the
The reason I didn't want to change |
Carelessly broke it in #37389