-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable monitoring flag is only available from GraalVM 22.3 onwards #37828
Conversation
@zakkak do we still support 22.2 in recent versions? I thought we moved away from it but it might be me misremembering. |
@gsmet If we don't support 22.2 any more, we should up the minimum version. Right now there's nothing stopping people using it. |
We don't even support it in older versions! 22.2 was released on Jul 27, 2022 and reached EOL in October 2022.
+1, the question is which version should we up the minimum to? 22.3 is still supported till April 2024, however AFAIK there are no workflows testing Quarkus The sensible thing to do would be to up the minimum to 23.0, but it might be worth keeping 22.3 just for doing cross-version comparisons. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but is probably not worth merging. 22.2 is not supported since Oct 2022, we should better up the minimum supported version as discussed in the comments.
@galderz where did you see we still support 22.2? |
@gsmet see quarkus/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/GraalVM.java Line 159 in 519b3ea
This is used to let users know if they are using an unsupported version or not. Right now using 22.2 doesn't show any warnings/errors. |
Failing Jobs - Building 7723401
You can also consult the Develocity build scans. |
Fair enough. Feel free to close this and send a new PR updating minimum GraalVM version when agreed. |
Follow up to quarkusio#37828 (comment) and quarkusio#39866 (comment) (cherry picked from commit 1b6033b)
Follow up to quarkusio#37828 (comment) and quarkusio#39866 (comment) (cherry picked from commit 1b6033b)
Follow up to quarkusio#37828 (comment) and quarkusio#39866 (comment) (cherry picked from commit 1b6033b)
Follow up to quarkusio#37828 (comment) and quarkusio#39866 (comment) (cherry picked from commit 1b6033b)
Fixes #37825