Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable monitoring flag is only available from GraalVM 22.3 onwards #37828

Closed

Conversation

galderz
Copy link
Member

@galderz galderz commented Dec 19, 2023

Fixes #37825

@galderz galderz requested a review from zakkak December 19, 2023 09:19
@gsmet
Copy link
Member

gsmet commented Dec 19, 2023

@zakkak do we still support 22.2 in recent versions? I thought we moved away from it but it might be me misremembering.

@galderz
Copy link
Member Author

galderz commented Dec 19, 2023

@gsmet If we don't support 22.2 any more, we should up the minimum version. Right now there's nothing stopping people using it.

@zakkak
Copy link
Contributor

zakkak commented Dec 19, 2023

@zakkak do we still support 22.2 in recent versions?

We don't even support it in older versions! 22.2 was released on Jul 27, 2022 and reached EOL in October 2022.

@gsmet If we don't support 22.2 any more, we should up the minimum version. Right now there's nothing stopping people using it.

+1, the question is which version should we up the minimum to?

22.3 is still supported till April 2024, however AFAIK there are no workflows testing Quarkus main with 22.3, we only test against Quarkus 2.13.

The sensible thing to do would be to up the minimum to 23.0, but it might be worth keeping 22.3 just for doing cross-version comparisons. Thoughts?

Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is probably not worth merging. 22.2 is not supported since Oct 2022, we should better up the minimum supported version as discussed in the comments.

@gsmet
Copy link
Member

gsmet commented Dec 19, 2023

@galderz where did you see we still support 22.2?

@zakkak
Copy link
Contributor

zakkak commented Dec 19, 2023

@galderz where did you see we still support 22.2?

@gsmet see

public static final Version MINIMUM = VERSION_22_2_0;

This is used to let users know if they are using an unsupported version or not. Right now using 22.2 doesn't show any warnings/errors.

Copy link

quarkus-bot bot commented Dec 19, 2023

Failing Jobs - Building 7723401

Status Name Step Failures Logs Raw logs Build scan
Native Tests - Security2 Update Docker Client User Agent ⚠️ Check → Logs Raw logs 🚧

You can also consult the Develocity build scans.

@galderz
Copy link
Member Author

galderz commented Dec 19, 2023

LGTM, but is probably not worth merging. 22.2 is not supported till Oct 2022, we should better up the minimum supported version as discussed in the comments.

Fair enough. Feel free to close this and send a new PR updating minimum GraalVM version when agreed.

@gsmet gsmet closed this Dec 22, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Dec 22, 2023
zakkak added a commit to zakkak/quarkus that referenced this pull request Apr 4, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Apr 9, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Apr 9, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Apr 9, 2024
ketola pushed a commit to ketola/quarkus that referenced this pull request May 1, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this pull request May 15, 2024
@galderz galderz deleted the topic.1219.enable-heapdump-only branch June 4, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add heap dump monitoring only when using a GraalVM version that supports it
3 participants