Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that @WithFormRead doesn't break body handling #38410

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 26, 2024

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geoand

@geoand
Copy link
Contributor Author

geoand commented Jan 26, 2024

🙏🏼

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 26, 2024
Copy link

quarkus-bot bot commented Jan 26, 2024

Failing Jobs - Building 93167f0

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
Maven Tests - JDK 17 Build Failures Logs Raw logs 🔍
✔️ Maven Tests - JDK 17 Windows 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/smallrye-context-propagation 

📦 integration-tests/smallrye-context-propagation

io.quarkus.context.test.mutiny.MutinyContextPropagationTest.testTransactionContextPropagationAsyncUni line 144 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

io.quarkus.context.test.mutiny.MutinyContextPropagationTest.testTransactionContextPropagationMulti line 153 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

io.quarkus.context.test.mutiny.MutinyContextPropagationTest.testTransactionNewContextPropagationSync line 138 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

⚙️ Maven Tests - JDK 17 #

- Failing: integration-tests/devmode 

📦 integration-tests/devmode

io.quarkus.test.devui.DevUIHibernateOrmActiveFalseTest.testGetNumberOfPersistenceUnits - More details - Source on GitHub

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.netty.deployment.NettyProcessor#cleanupUnsafeLog threw an exception: java.lang.OutOfMemoryError: Metaspace
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:508)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:468)
	at io.quarkus.netty.deployment.NettyProcessor.cleanupUnsafeLog(NettyProcessor.java:286)

@geoand geoand merged commit 7e2b397 into quarkusio:main Jan 26, 2024
42 of 44 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 26, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 26, 2024
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.1 Jan 26, 2024
@geoand geoand deleted the #38326 branch January 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-Site Request Forgery (CSRF) prevents JSON-Bodies to be deserialized
3 participants