Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC: RequestContext - implement the activity check consistently #38605

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 6, 2024

In theory, this could break something because previously it was possible to call RequestContext#destroy() and then still use a client proxy to obtain a contextual reference. Which is obviously wrong but our API docs are not exactly clear in this area 🤷.

@mkouba mkouba requested review from Ladicek and manovotn February 6, 2024 12:25
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Feb 6, 2024
@Ladicek
Copy link
Contributor

Ladicek commented Feb 6, 2024

Looks good, but I too am wondering how many tests will break :-)

@manovotn
Copy link
Contributor

manovotn commented Feb 6, 2024

Looks good, but I too am wondering how many tests will break :-)

What could possibly go wrong when context propagation is involved, right? :)

Copy link

quarkus-bot bot commented Feb 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7db82da.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba
Copy link
Contributor Author

mkouba commented Feb 6, 2024

It's unbelievable but all CI checks passed :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants