Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi rooted path tree scanning in the Qute processor #40400

Merged

Conversation

aloubyansky
Copy link
Member

@aloubyansky aloubyansky commented May 1, 2024

@aloubyansky aloubyansky requested a review from mkouba May 1, 2024 20:03
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/qute The template engine labels May 1, 2024
@aloubyansky aloubyansky force-pushed the fix-multi-rooted-trees-for-qute branch from 06fe225 to 195deab Compare May 1, 2024 20:14
Copy link

quarkus-bot bot commented May 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 195deab.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - HTTP Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ Native Tests - HTTP #

- Failing: integration-tests/rest-client 

📦 integration-tests/rest-client

Failed to execute goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore (self-signed-truststore) on project quarkus-integration-test-rest-client: Execution self-signed-truststore of goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore failed: Unable to establish TLS connection with: self-signed.badssl.com:443

@aloubyansky
Copy link
Member Author

Given #40158 has backport-3.8 label, i added it to this PR as well

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

So if I understand well:
You use the getRelativePath which is directly using the given path separator, so no os problems. Also the relativise doesn't need to be done using the full Path, it's just stripping a part of the string, therefore no fs issues.

@ia3andy ia3andy merged commit 0f29d73 into quarkusio:main May 2, 2024
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 2, 2024
@mkouba
Copy link
Contributor

mkouba commented May 2, 2024

Looks good but I wanted to add a test with src/main/resources/templates and src/test/resources/templates template roots. But never mind, I'll add one in a follow-up pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/qute The template engine kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute-Templates cannot be found in tests if directory "src/test/resources/templates" exist
4 participants