-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi rooted path tree scanning in the Qute processor #40400
Fix multi rooted path tree scanning in the Qute processor #40400
Conversation
06fe225
to
195deab
Compare
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | Native Tests - HTTP | Build |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ Native Tests - HTTP #
- Failing: integration-tests/rest-client
📦 integration-tests/rest-client
✖ Failed to execute goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore (self-signed-truststore) on project quarkus-integration-test-rest-client: Execution self-signed-truststore of goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore failed: Unable to establish TLS connection with: self-signed.badssl.com:443
Given #40158 has |
independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/PathVisit.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
So if I understand well:
You use the getRelativePath
which is directly using the given path separator, so no os problems. Also the relativise doesn't need to be done using the full Path, it's just stripping a part of the string, therefore no fs issues.
Looks good but I wanted to add a test with |
Fix #40366 and quarkiverse/quarkus-web-bundler#197