Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets Next: fire CDI event when a connection is opened/closed #41032

Merged
merged 1 commit into from
Jun 7, 2024
Merged

WebSockets Next: fire CDI event when a connection is opened/closed #41032

merged 1 commit into from
Jun 7, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 6, 2024

@mkouba mkouba requested a review from manovotn June 6, 2024 15:20
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 6, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c5663f9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 6, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c5663f9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

manovotn
manovotn approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Also, keeping the events just async seems reasonable 👍

@manovotn manovotn merged commit a847dae into quarkusio:main Jun 7, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 7, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 7, 2024
@michalvavrik michalvavrik mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement New feature or request
Projects
Quarkus Documentation
Status: Done
Milestone
3.12.0.CR1
Development

Successfully merging this pull request may close these issues.

WebSockets Next: fire CDI events for each connection added/removed
2 participants
@mkouba @manovotn