Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusComponentTest: fix NPE if component is expected but none exists #41205

Merged
merged 1 commit into from
Jun 14, 2024
Merged

QuarkusComponentTest: fix NPE if component is expected but none exists #41205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...nit5-component/src/main/java/io/quarkus/test/component/QuarkusComponentTestExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,18 +1097,25 @@ public FieldInjector(Field field, Object testInstance) throws Exception {
} else {
InstanceHandle<?> handle = container.instance(requiredType, qualifiers);
if (field.isAnnotationPresent(Inject.class)) {
if (!handle.isAvailable()) {
throw new IllegalStateException(String
.format("The injected field [%s] expects a real component; but no matching component was registered",
field,
handle.getBean()));
}
if (handle.getBean().getKind() == io.quarkus.arc.InjectableBean.Kind.SYNTHETIC) {
throw new IllegalStateException(String
.format("The injected field %s expects a real component; but obtained: %s", field,
.format("The injected field [%s] expects a real component; but obtained: %s", field,
handle.getBean()));
}
} else {
if (!handle.isAvailable()) {
throw new IllegalStateException(String
.format("The injected field %s expects a mocked bean; but obtained null", field));
} else if (handle.getBean().getKind() != io.quarkus.arc.InjectableBean.Kind.SYNTHETIC) {
.format("The injected field [%s] expects a mocked bean; but obtained null", field));
}
if (handle.getBean().getKind() != io.quarkus.arc.InjectableBean.Kind.SYNTHETIC) {
throw new IllegalStateException(String
.format("The injected field %s expects a mocked bean; but obtained: %s", field,
.format("The injected field [%s] expects a mocked bean; but obtained: %s", field,
handle.getBean()));
}
}
Expand Down
Loading