Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build warning #4130

Merged
merged 1 commit into from
Sep 20, 2019
Merged

fix: build warning #4130

merged 1 commit into from
Sep 20, 2019

Conversation

machi1990
Copy link
Member

Follows up #4089

/cc @gsmet @geoand for a quick review.

@machi1990 machi1990 requested a review from gsmet September 20, 2019 12:00
@geoand
Copy link
Contributor

geoand commented Sep 20, 2019

Thanks @machi1990

@gsmet
Copy link
Member

gsmet commented Sep 20, 2019

Hmmm, it looks a lot like this PR of mine? https://github.com/quarkusio/quarkus/pull/4089/files

It has been merged so I'm surprised it's not fixed.

@machi1990
Copy link
Member Author

Hmmm, it looks a lot like this PR of mine? https://github.com/quarkusio/quarkus/pull/4089/files

It has been merged so I'm surprised it's not fixed.

Yes, I was surprised to find these leftovers - the profiles part was not modified.

@machi1990 machi1990 added this to the 0.24.0 milestone Sep 20, 2019
@gsmet
Copy link
Member

gsmet commented Sep 20, 2019

Aaaaah, OK, I missed the changes were in the native profiles :).

Good catch, thanks!

@gsmet gsmet merged commit d51d17c into quarkusio:master Sep 20, 2019
@machi1990 machi1990 deleted the misc-build-warning branch September 20, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants