Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gRPC 1.65.0 and Netty 4.1.111 #41578

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Update to gRPC 1.65.0 and Netty 4.1.111 #41578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
<infinispan.version>15.0.5.Final</infinispan.version>
<infinispan.protostream.version>5.0.5.Final</infinispan.protostream.version>
<caffeine.version>3.1.5</caffeine.version>
<netty.version>4.1.110.Final</netty.version>
<netty.version>4.1.111.Final</netty.version>
<brotli4j.version>1.16.0</brotli4j.version>
<reactive-streams.version>1.0.4</reactive-streams.version>
<jboss-logging.version>3.6.0.Final</jboss-logging.version>
Expand Down
2 changes: 0 additions & 2 deletions docs/src/main/asciidoc/grpc-service-consumption.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,9 @@
The following examples uses _hello_ as the client name.
Don't forget to replace it with the name you used in the `@GrpcClient` annotation.

IMPORTANT: When you enable `quarkus.grpc.clients."client-name".use-quarkus-grpc-client`, you are then using the new Vert.x gRPC channel implementation, so not all configuration properties can still be applied. And currently there is no Stork support yet.

IMPORTANT: When you enable `quarkus.grpc.clients."client-name".xds.enabled`, it's the xDS that should handle most of the configuration above.

=== Enabling TLS

Check warning on line 216 in docs/src/main/asciidoc/grpc-service-consumption.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Headings] Use sentence-style capitalization in 'Enabling TLS'.

Raw Output:
{"message": "[Quarkus.Headings] Use sentence-style capitalization in 'Enabling TLS'.", "location": {"path": "docs/src/main/asciidoc/grpc-service-consumption.adoc", "range": {"start": {"line": 216, "column": 5}}}, "severity": "INFO"}

To enable TLS, use the following configuration.
Note that all paths in the configuration may either specify a resource on the classpath
Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/stork-reference.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ include::{includes}/extension-status.adoc[]
The current integration of Stork supports:

* the REST Client
* the gRPC clients
* the gRPC clients (using the Vert.x gRPC client is recommended)

Warning: The gRPC client integration does not support statistic-based load balancers.

Expand Down
9 changes: 9 additions & 0 deletions ...ime/src/test/java/io/quarkus/grpc/examples/stork/GrpcStorkResponseTimeCollectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
package io.quarkus.grpc.examples.stork;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import io.quarkus.test.junit.QuarkusTest;

@QuarkusTest
class GrpcStorkResponseTimeCollectionTest extends GrpcStorkResponseTimeCollectionTestBase {

@Test
@Disabled("Disabled because of https://github.com/grpc/grpc-java/commit/8844cf7b87a04dd2d2e4a74cd0f0e3f4fed14113 which does not call the load balancer for each call anymore.")
public void shouldCallConfigurableIfFaster() {

}
}
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@
<hibernate-search.version>7.1.1.Final</hibernate-search.version>

<!-- Make sure to check compatibility between these 2 gRPC components before upgrade -->
<grpc.version>1.64.0</grpc.version> <!-- when updating, verify if com.google.auth should not be updated too -->
<grpc-jprotoc.version>1.2.1</grpc-jprotoc.version>
<protoc.version>3.25.0</protoc.version>
<grpc.version>1.65.0</grpc.version> <!-- when updating, verify if com.google.auth should not be updated too -->
<grpc-jprotoc.version>1.2.2</grpc-jprotoc.version>
<protoc.version>3.25.3</protoc.version>
<protobuf-java.version>${protoc.version}</protobuf-java.version>
<proto-google-common-protos.version>2.41.0</proto-google-common-protos.version>

Expand Down
Loading