-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid storing timestamp in Gradle.properties #41762
Conversation
gastaldi
commented
Jul 8, 2024
- Fixes Running Quarkus CLI rewrites gradle.properties #41182
Does it also avoid rewriting the file and respect the formatting of the existing file? Because I think that's what the original issue was about. |
@gsmet yes, I tested locally and the order is preserved. In another words, running the steps from the original issue does not change the properties file |
This comment has been minimized.
This comment has been minimized.
try (StringWriter sw = new StringWriter()) { | ||
getModel().getRootPropertiesContent().store(sw, "Gradle properties"); | ||
Files.writeString(rootProjectPath.resolve(GRADLE_PROPERTIES_PATH), | ||
sw.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using StringWriter
because of codejive/java-properties#23
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement. I will merge.
Could you have a look at what @radcortez did in the quarkus config
CLI? Maybe it would benefit from this too.
awesome stuff @gastaldi ! |