Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump artemis-jms to 2.10.0 #4184

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Bump artemis-jms to 2.10.0 #4184

merged 1 commit into from
Sep 25, 2019

Conversation

gastaldi
Copy link
Contributor

No description provided.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 24, 2019
@geoand
Copy link
Contributor

geoand commented Sep 24, 2019

Seem like the change isn't enough:

[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce) @ quarkus-integration-test-artemis-jms ---
[WARNING] 
Dependency convergence error for org.apache.activemq:artemis-commons:2.9.0 paths to dependency are:
+-io.quarkus:quarkus-integration-test-artemis-jms:999-SNAPSHOT
  +-io.quarkus:quarkus-artemis-jms:999-SNAPSHOT
    +-io.quarkus:quarkus-artemis-core:999-SNAPSHOT
      +-org.apache.activemq:artemis-core-client:2.10.0
        +-org.apache.activemq:artemis-commons:2.9.0
and
+-io.quarkus:quarkus-integration-test-artemis-jms:999-SNAPSHOT
  +-io.quarkus:quarkus-artemis-jms:999-SNAPSHOT
    +-org.apache.activemq:artemis-jms-client:2.10.0
      +-org.apache.activemq:artemis-selector:2.9.0
        +-org.apache.activemq:artemis-commons:2.10.0
and
+-io.quarkus:quarkus-integration-test-artemis-jms:999-SNAPSHOT
  +-org.apache.activemq:artemis-server:2.9.0
    +-org.apache.activemq:artemis-commons:2.9.0
and
+-io.quarkus:quarkus-integration-test-artemis-jms:999-SNAPSHOT
  +-org.apache.activemq:artemis-server:2.9.0
    +-org.apache.activemq:artemis-journal:2.9.0
      +-org.apache.activemq:artemis-commons:2.9.0
and
+-io.quarkus:quarkus-integration-test-artemis-jms:999-SNAPSHOT
  +-org.apache.activemq:artemis-server:2.9.0
    +-org.apache.activemq:artemis-jdbc-store:2.9.0
      +-org.apache.activemq:artemis-commons:2.9.0

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
Failed while enforcing releasability. See above detailed error message.

@geoand geoand added coding-in-progress and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 24, 2019
@gastaldi
Copy link
Contributor Author

@geoand oops, forgot to change in build-parent. Done

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed coding-in-progress labels Sep 24, 2019
@geoand
Copy link
Contributor

geoand commented Sep 24, 2019

@gsmet is there any specific reason we have the artemis version in both places?

@gastaldi
Copy link
Contributor Author

The artemis-server used in the integration-tests isn't declared in the runtime BOM (not sure why), perhaps @middagj may explain?

@middagj
Copy link
Contributor

middagj commented Sep 24, 2019

The server is only used in the integration tests to test the client. I took Kafka as an example, there this is also the case.

@geoand geoand merged commit 774449d into quarkusio:master Sep 25, 2019
@geoand geoand added this to the 0.24.0 milestone Sep 25, 2019
@gastaldi gastaldi deleted the patch-1 branch October 8, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gastaldi @geoand @middagj @gsmet