Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtls-certificates: Fail on transport, not network level (wrong port) #42156

Merged
merged 1 commit into from
Aug 2, 2024
+16 −10
Merged

mtls-certificates: Fail on transport, not network level (wrong port) #42156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions integration-tests/mtls-certificates/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@ quarkus.http.ssl.certificate.trust-store-file=server-truststore.p12
quarkus.http.ssl.certificate.trust-store-password=password
quarkus.http.ssl.client-auth=REQUIRED
quarkus.http.auth.certificate-role-properties=cn-role-mappings.txt
quarkus.native.additional-build-args=-H:IncludeResources=.*\\.p12,-H:IncludeResources=.*\\.txt

quarkus.native.resources.includes=*.p12,*.txt
23 changes: 15 additions & 8 deletions ...ls-certificates/src/test/java/io/quarkus/it/vertx/AbstractCertificateRoleMappingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
import static org.hamcrest.Matchers.equalTo;
import static org.junit.jupiter.api.Assertions.assertThrows;

import java.net.ConnectException;
import java.net.URL;

import javax.net.ssl.SSLHandshakeException;

import org.junit.jupiter.api.Test;

import io.quarkus.test.common.http.TestHTTPResource;
Expand Down Expand Up @@ -44,19 +45,25 @@ public void testAuthorizedAdmin() {

@Test
public void testNoClientCertificate() {
assertThrows(ConnectException.class,
() -> given().get("/protected/authenticated"),
// javax.net.ssl.SSLHandshakeException
// Indicates that the client and server could not negotiate the desired level of security.
// The connection is no longer usable.
final RequestSpecification rs = new RequestSpecBuilder()
.setBaseUri(String.format("%s://%s", url.getProtocol(), url.getHost()))
.setPort(url.getPort()).build();
assertThrows(SSLHandshakeException.class,
() -> given().spec(rs).get("/protected/authenticated"),
"Insecure requests must fail at the transport level");
assertThrows(ConnectException.class,
() -> given().get("/protected/authorized-user"),
assertThrows(SSLHandshakeException.class,
() -> given().spec(rs).get("/protected/authorized-user"),
"Insecure requests must fail at the transport level");
assertThrows(ConnectException.class,
() -> given().get("/protected/authorized-admin"),
assertThrows(SSLHandshakeException.class,
() -> given().spec(rs).get("/protected/authorized-admin"),
"Insecure requests must fail at the transport level");
}

protected RequestSpecification getMtlsRequestSpec(String clientKeyStore) {
var builder = new RequestSpecBuilder()
final RequestSpecBuilder builder = new RequestSpecBuilder()
.setBaseUri(String.format("%s://%s", url.getProtocol(), url.getHost()))
.setPort(url.getPort());
withKeyStore(builder, clientKeyStore);
Expand Down