Allow disabling health extension with configuration #42361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
gsmet
requested changes
Aug 7, 2024
| * Activate or disable this extension. Disabling this extension means that no health related information is exposed. | ||
| */ | ||
| @ConfigItem(name = "active", defaultValue = "true") | ||
| public boolean active; |
There was a problem hiding this comment.
If you disable the extension entirely, please use enabled, not active.
Also don't define a name, the convention will make it right.
See this issue for the overall context: #42244
xstefank
force-pushed
the
disable-health-i42356
branch
from
d7a842c to
71f02d7
Compare
|
@gsmet fixed. I also aligned that it will always produce the feature so it will be displayed on startup to align with hibernate. |
Status for workflow
|
gsmet
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42356