You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this is a breaking change for native queries (see the updated tests), I think we shouldn't have to add the [] when dealing with lists: that's not something you do in HQL, it shouldn't be something you have to do in native. You have your parameter as ?1 and if the value is a list, it gets properly encoded.
@loicmathieu could you have a look at this one? I think it's for the better.
Note that I had some weird test failures that might or might not be related locally but I couldn't reproduce them when running the failing test in isolation so I'm not sure what's going on...
While this is a breaking change for native, I think we shouldn't have to
add the [] when dealing with lists: that's not something you do in HQL,
it shouldn't be something you have to do in native.
Fixesquarkusio#27326
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is a breaking change for native queries (see the updated tests), I think we shouldn't have to add the [] when dealing with lists: that's not something you do in HQL, it shouldn't be something you have to do in native. You have your parameter as
?1and if the value is a list, it gets properly encoded.Fixes #27326
@loicmathieu could you have a look at this one? I think it's for the better.
Note that I had some weird test failures that might or might not be related locally but I couldn't reproduce them when running the failing test in isolation so I'm not sure what's going on...