-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for collection of java.time in query params #42731
Support for collection of java.time in query params #42731
Conversation
@geoand can you please review this PR? If it's ok would it be possible to have this in the 3.14.1? Thank you very much. |
Thanks for this. I'm on PTO currently, I'll review when I get back |
cc @FroMage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except the condition which should be simplified and harmonised, but great work, thanks :)
@@ -676,6 +678,14 @@ private ParameterConverterSupplier extractConverter(String elementType, IndexVie | |||
|| elementType.equals(InputStream.class.getName())) { | |||
// this is handled by MultipartFormParamExtractor | |||
return null; | |||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something like this would be a better condition:
} else if (SUPPORT_TEMPORAL_PARAMS.contains(DotName.createSimple(elementType))) {
This is what is done in handleOptionalParam
already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now should be ok. Thanks
Oh, and could you also please merge your commits? |
Done |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
@FroMage is it possible to have this in a patch of 3.14? |
Hello, we need to support collection of dates in our endpoint.
This PR enable to usage of this kind of endpoints
public void myEndpoint(@RestQuery Set<LocalDate> dates)