Add Jose4j static init recording to OIDC #42765
Conversation
sberyozkin
commented
Aug 26, 2024
•
sberyozkin
commented
- Fixes: Quarkus OIDC makes first request very slow #41452
This comment has been minimized.
This comment has been minimized.
|
Hi @gsmet @aloubyansky, I've seen this Gradle build failure a few times before, it looked transient, I meant to open a separate issue |
sberyozkin
force-pushed
the
oidc_jose4j_recorder
branch
from
51cef22 to
24d15c2
Compare
Status for workflow
|
| public class Jose4jRecorder { | ||
|
|
||
| public void initialize() { | ||
| AlgorithmFactoryFactory.getInstance(); |
There was a problem hiding this comment.
This uses System.getProperty which should never be used to configure behavior at native-image build time.
To be fair, it seems to use it only for logging, but it makes suspicious of what else this method does and it absolutely needs to be checked thoroughly
There was a problem hiding this comment.
Hi @geoand, sure, https://bitbucket.org/b_c/jose4j/src/756257eb92352600d5dde08c2b8ed25db13a8952/src/main/java/org/jose4j/jwa/AlgorithmFactoryFactory.java#lines-56 is indeed about logging only...
The rest of the method is sound, these properties are not having any impact.
Are you OK with that ? I can suggest to move those System.getProperty() calls directly into log.debug(...) if it can make any difference
There was a problem hiding this comment.
The rest of the method is sound, these properties are not having any impact.
If you have checked it thoroughly, that's fine with me.
There was a problem hiding this comment.
@geoand Yeah, I searched if any of those properties can be seen somewhere else in that code :-). The rest is just loading supported algorithms, none of them would need a version/vendor/javahome property. I suppose, purely for debugging purposes, seeing Java version and vendor can be useful in context of the Jose4j initialization as a support for various algorithms may vary...
Agreed it was not really essential though
|
Let me merge now that we've discussed Georgios's comment |
