Revert "Adding new WithTestResource annotation"

[gsmet]

This reverts commit 5717408.

Also revert "Removed missed deprecated @QuarkusTestResource from docs"
This reverts commit 6588ea3.

And more as it was more involved than that, since some tests were removed, modified, added since then.

No idea if all the tests will pass though, we will see how it goes...

[quarkus-bot]

/cc @marko-bekhta (hibernate-search), @yrodiere (hibernate-orm,hibernate-search)

[gsmet]

Note that I kept the new annotation so it's not a full revert.

[geoand]

Yeah, I had no doubt 🙂

[github-actions]

🙈 The PR is closed and the preview is expired.

[jedla97]

When this will be merged we probably want also revert quarkusio/quarkus-quickstarts#1435 for guides to be in sync with quickstarts.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 451d196.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[famod]

Since I have migrated my project to WithTestResource, why is it being reverted? Thanks!

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 451d196.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	JVM Tests - JDK 17	Build	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 21	Build	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 17 Windows	Build	Failures	Logs	Raw logs	🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/grpc-cli 

📦 integration-tests/grpc-cli

✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy28.corsHandler(Unknown Source)
	at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)

---

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/grpc-cli 

📦 integration-tests/grpc-cli

✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy28.corsHandler(Unknown Source)
	at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)

---

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/grpc-cli 

📦 integration-tests/grpc-cli

✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy25.corsHandler(Unknown Source)
	at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer/deployment

✖ io.quarkus.micrometer.deployment.binder.VertxTcpMetricsNoClientMetricsTest.testTcpMetricsWithoutClientMetrics - History

• event executor terminated - java.util.concurrent.RejectedExecutionException

java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

[gsmet]

@famod you can find more context here: https://groups.google.com/g/quarkus-dev/c/rS8-WN6b7XQ

You don't have to change anything for now, you can keep your @WithTestResource around. We just want to avoid more people to migrate given the problems mentioned in this thread.