Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc - support @All List<X> synthetic injection points #43069

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Sep 6, 2024

Fixes #42834

@manovotn manovotn requested a review from mkouba September 6, 2024 05:52
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Sep 6, 2024
@manovotn
Copy link
Contributor Author

manovotn commented Sep 6, 2024

Updated PR as per comments

Copy link

quarkus-bot bot commented Sep 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9e43202.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

io.quarkus.test.devui.DevUIHibernateOrmActiveFalseTest.testGetNumberOfEntityTypes - History

  • java.lang.OutOfMemoryError: Metaspace - io.quarkus.dev.appstate.ApplicationStartException
io.quarkus.dev.appstate.ApplicationStartException: java.lang.OutOfMemoryError: Metaspace
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:63)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:142)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.firstStart(IsolatedDevModeMain.java:91)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:428)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:55)
	at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:138)
	at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:93)

@mkouba mkouba merged commit 7a16604 into quarkusio:main Sep 9, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 9, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 9, 2024
@manovotn manovotn deleted the issue42834 branch September 9, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArC: synthetic injection points should support @Inject @All List<>
3 participants