Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration property to customize the directory where decompilation output gets stored #43076

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Sep 6, 2024

The new property is quarkus.package.jar.decompiler.output-dir.

@yrodiere
Copy link
Member Author

yrodiere commented Sep 6, 2024

Note this is mostly to align on e.g. quarkus.debug.transformed-classes-dir.

I would have just replaced quarkus.package.jar.decompiler.enabled with quarkus.package.jar.decompiler.output-dir, but, well, backwards compatibility.

Copy link

quarkus-bot bot commented Sep 6, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fd58e50.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented Sep 6, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Sep 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fd58e50.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@gsmet gsmet merged commit 613cdf3 into quarkusio:main Sep 7, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 7, 2024
@yrodiere yrodiere deleted the custom-decompiler-dir branch October 3, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants