Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the type of Http Request we get in a filter #4310

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions docs/src/main/asciidoc/rest-json-guide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -426,16 +426,15 @@ Let's use `ContainerRequestFilter` to add logging capability to our service. We
----
package org.acme.rest.json;

import javax.servlet.http.HttpServletRequest;
import io.vertx.core.http.HttpServerRequest;
import org.jboss.logging.Logger;

import javax.ws.rs.container.ContainerRequestContext;
import javax.ws.rs.container.ContainerRequestFilter;
import javax.ws.rs.core.Context;
import javax.ws.rs.core.UriInfo;
import javax.ws.rs.ext.Provider;

import org.jboss.logging.Logger;


@Provider
public class LoggingFilter implements ContainerRequestFilter {

Expand All @@ -445,14 +444,14 @@ public class LoggingFilter implements ContainerRequestFilter {
UriInfo info;

@Context
HttpServletRequest request;
HttpServerRequest request;

@Override
public void filter(ContainerRequestContext context) {

final String method = context.getMethod();
final String path = info.getPath();
final String address = request.getRemoteAddr();
final String address = request.remoteAddress().toString();

LOG.infof("Request %s %s from IP %s", method, path, address);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
package io.quarkus.resteasy.test;

import javax.ws.rs.GET;
import javax.ws.rs.Path;
import javax.ws.rs.core.Context;
import javax.ws.rs.core.SecurityContext;

import org.jboss.shrinkwrap.api.ShrinkWrap;
import org.jboss.shrinkwrap.api.spec.JavaArchive;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

import io.quarkus.test.QuarkusUnitTest;
import io.restassured.RestAssured;
import io.vertx.core.Vertx;
import io.vertx.core.http.HttpServerRequest;
import io.vertx.core.http.HttpServerResponse;
import io.vertx.ext.web.RoutingContext;

public class ContextTest {

@RegisterExtension
static QuarkusUnitTest runner = new QuarkusUnitTest()
.setArchiveProducer(() -> ShrinkWrap.create(JavaArchive.class)
.addClasses(MyResource.class));

@Test
public void testContextInjection() {
Assertions.assertEquals("ok", RestAssured.get("/ctxt").asString());
}

@Path("/ctxt")
public static class MyResource {
@Context
HttpServerRequest request;
@Context
HttpServerResponse response;
@Context
Vertx vertx;
@Context
io.vertx.core.Context vertxContext;
@Context
SecurityContext securityContext;
@Context
RoutingContext rc;

@GET
public String test() {
if (request == null || request.path() == null) {
throw new IllegalStateException("Request not injected");
}
if (response == null) {
throw new IllegalStateException("Response not injected");
}
if (rc == null) {
throw new IllegalStateException("Routing Context not injected");
}
if (vertx == null) {
throw new IllegalStateException("Vert.x not injected");
}
if (vertxContext == null) {
throw new IllegalStateException("Vert.x context not injected");
}
if (securityContext == null) {
throw new IllegalStateException("Security context not injected");
}
return "ok";
}
}
}