Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor wording issues in integration tests README.md #4384

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Fix minor wording issues in integration tests README.md #4384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration-tests/hibernate-search-elasticsearch/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Hibernate Search example with ElasticSearch
# Hibernate Search example with Elasticsearch

## Running the tests

By default, the tests of this module are disabled.

To run the tests in a standard JVM with ElasticSearch started in the JVM, you can run the following command:
To run the tests in a standard JVM with Elasticsearch started in the JVM, you can run the following command:

```
mvn clean install -Dtest-elasticsearch
Expand Down
4 changes: 2 additions & 2 deletions integration-tests/reactive-mysql-client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

By default, the tests of this module are disabled.

To run the tests in a standard JVM with MySQL started as a Docker container, you can run the following command:
To run the tests in a standard JVM with MariaDB started as a Docker container, you can run the following command:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is called reactive-mysql-client: why is it using MariaDB for testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I suppose it supports both? I haven't changed it, just made the README state what the code does. @tsegismont wrote this IIRC.


```
mvn clean install -Dtest-mariadb -Ddocker
Expand All @@ -16,7 +16,7 @@ Additionally, you can generate a native image and run the tests for this native
mvn clean install -Dtest-mariadb -Ddocker -Dnative
```

If you don't want to run MySQL as a Docker container, you can start your own MySQL server. It needs to listen on the default port and have a database called `hibernate_orm_test` accessible to the user `hibernate_orm_test` with the password `hibernate_orm_test`.
If you don't want to run MariaDB as a Docker container, you can start your own MariaDB or MySQL server. It needs to listen on the default port and have a database called `hibernate_orm_test` accessible to the user `hibernate_orm_test` with the password `hibernate_orm_test`.

You can then run the tests as follows (either with `-Dnative` or not):

Expand Down