Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to rebase in the Contributing guide #44226

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Oct 31, 2024

An attempt to explain how to rebase as I'm seeing a few PRs failing regularly, Guillaume, please tell me how to improve it :-), or don't hesitate to replace it completely with an easier recommendation

@sberyozkin sberyozkin requested a review from gsmet October 31, 2024 13:52
@gsmet
Copy link
Member

gsmet commented Oct 31, 2024

@sberyozkin I added a second commit with some improvements, let me know if that works for you.

@sberyozkin
Copy link
Member Author

Thanks @gsmet for polishing it, cheers

@gsmet gsmet merged commit 98eaa3b into quarkusio:main Nov 5, 2024
3 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants