Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a left-over TODO statement #44359

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

cescoffier
Copy link
Member

The test mentioned in the TODO has been implemented in a previous PR.

The test mentioned in the TODO has been implemented in a previous PR.
@cescoffier cescoffier added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Nov 7, 2024
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 7, 2024
@gsmet gsmet merged commit f8d0e77 into quarkusio:main Nov 7, 2024
52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 7, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 7, 2024
Copy link

quarkus-bot bot commented Nov 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 90d1602.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/oidc-code-flow

io.quarkus.it.keycloak.CodeFlowTest.testTokenRefresh - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at io.quarkus.it.keycloak.CodeFlowTest$3.call(CodeFlowTest.java:733)
	at io.quarkus.it.keycloak.CodeFlowTest$3.call(CodeFlowTest.java:720)
	at org.awaitility.core.CallableCondition$ConditionEvaluationWrapper.eval(CallableCondition.java:99)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)

@cescoffier cescoffier deleted the remove-todo branch November 14, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants