Removing redundant code, adding jwks_path property #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note credentials.secret property is still obviously supported but until we have a test confirming it is supported at the Vertx level with a test, it is probably better not to type it everywhere :-) Pedro may help with a test so we'll make it visible asap |
|
|
||
| // RFC7662 JWKS service address | ||
| if (config.jwksPath.isPresent()) { | ||
| options.setIntrospectionPath(config.jwksPath.get()); |
There was a problem hiding this comment.
This looks like a copy/paste error?
There was a problem hiding this comment.
It does, thanks for catching it
There was a problem hiding this comment.
Funny, I was staring at the code yesterday evening for a long time :-)
|
@stuartwdouglas, @gsmet Not sure if it is already too late for 0.24.0, that temp code was really my target, I'll add a 0.24.0 milestone, Guillaume, please move it to 0.25.0 if it is too tight |
gsmet
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed some code which was marked for the deletion, and also remove the doc references to the secret properties since it is not tested right now, so I don't know if we can doc it right now. I propose to doc only those properties which are being tested.
Thanks