Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyedits for style, security-jwt-build.adoc #44603

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 20, 2024

This PR includes copy edits to enhance clarity, improve consistency, and align the content with style guidelines for a better reader experience.

Copy link

quarkus-bot bot commented Nov 20, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

Copy link

github-actions bot commented Nov 20, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@rolfedh rolfedh force-pushed the revise-security-jwt-build.adoc branch from a9ba371 to 4ad8338 Compare November 20, 2024 18:33

This comment has been minimized.

@rolfedh rolfedh force-pushed the revise-security-jwt-build.adoc branch from 4ad8338 to d24b4a3 Compare November 20, 2024 20:41
@rolfedh rolfedh changed the title [WIP] Copyedits for style, security-jwt-build.adoc Copyedits for style, security-jwt-build.adoc Nov 20, 2024
@rolfedh rolfedh requested a review from sberyozkin November 20, 2024 20:42
@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 20, 2024

Hi, @sberyozkin. Please review and comment on this revision. Thank you.

This comment has been minimized.

@rolfedh rolfedh force-pushed the revise-security-jwt-build.adoc branch from d24b4a3 to c42c641 Compare November 21, 2024 13:54
@rolfedh rolfedh force-pushed the revise-security-jwt-build.adoc branch from c42c641 to e112485 Compare November 21, 2024 14:41
@rolfedh rolfedh force-pushed the revise-security-jwt-build.adoc branch from e112485 to 0afb875 Compare November 21, 2024 14:59

This comment has been minimized.

@sberyozkin
Copy link
Member

Sorry @rolfedh, I don't mean to be too pedantic, these are last proposed updates, it is just saying a algorithm for the key does not read well, the key is just a blob, and it can be used for different purposes...

@rolfedh rolfedh force-pushed the revise-security-jwt-build.adoc branch from 0afb875 to 70aabf3 Compare November 21, 2024 15:56
@rolfedh rolfedh force-pushed the revise-security-jwt-build.adoc branch from 70aabf3 to b8b2675 Compare November 21, 2024 16:03
@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 21, 2024

Sorry @rolfedh, I don't mean to be...

Not at all, @sberyozkin! Refining content is an iterative process and I appreciate all your contributions. Please let me know if you spot anything else we can improve.

@sberyozkin
Copy link
Member

Thanks very much @rolfedh, good to see this text being so nicely polished, thanks for that, my suggestions were very minor ones...

@sberyozkin sberyozkin self-requested a review November 21, 2024 16:13
Copy link

quarkus-bot bot commented Nov 21, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b8b2675.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin merged commit 16759d4 into quarkusio:main Nov 21, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 21, 2024
@sberyozkin sberyozkin deleted the revise-security-jwt-build.adoc branch November 21, 2024 16:54
@rolfedh rolfedh mentioned this pull request Nov 25, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.1 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants