Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with RESTEasy GET requests when using standalone vert.x #4466

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Fix issue with RESTEasy GET requests when using standalone vert.x #4466

merged 3 commits into from
Oct 9, 2019

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 9, 2019

Supersedes: #4465

@geoand geoand mentioned this pull request Oct 9, 2019
Closed
@gsmet gsmet added this to the 0.24.0 milestone Oct 9, 2019
gsmet
gsmet approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart that the test doesn't trigger the issue so we will need to tweak it. Let's do it later so that we can merge this.

@geoand
Copy link
Contributor Author

geoand commented Oct 9, 2019

The new test that was added now does fail without the fix in the first commit so it should able of catching similar regressions in the future

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 9, 2019
@gsmet
Copy link
Member

gsmet commented Oct 9, 2019

Perfect, let's wait for CI.

@geoand geoand merged commit 409c100 into quarkusio:master Oct 9, 2019
@geoand geoand deleted the vertx-get branch October 9, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @gsmet @stuartwdouglas