Fix conditional dependency resolution when runtime-deployment dependencies are not mirrored #44666
+502
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependencies are not mirrored
quarkus-bot
bot
added
area/core
area/devtools
aloubyansky
changed the title
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
geoand
reviewed
Nov 25, 2024
| @Override | ||
| protected BootstrapAppModelResolver newAppModelResolver(LocalProject currentProject) throws Exception { | ||
| var resolver = super.newAppModelResolver(currentProject); | ||
| // resolver.setIncubatingModelResolver(true); |
There was a problem hiding this comment.
Is this commented out code needed? The same applies to a few more places in the PR
There was a problem hiding this comment.
There is a global switch to enable the incubating impl but it's more convenient to do it this way when testing in an IDE. I can remove it in a couple of subsequent PRs (on the way).
geoand
reviewed
Nov 25, 2024
| deps.add(dep); | ||
| } else { | ||
| deps.add(dep); | ||
| Collections.rotate(deps, 1); |
geoand
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/conditional.20dependency.20with.20multiple.20layer.20of.20dependency/near/482870695
Tests included.
Also includes doc adjustments in the second commit pointed out in #44424