-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strengthen tests for @QuarkusMain #45000
Strengthen tests for @QuarkusMain #45000
Conversation
This comment has been minimized.
This comment has been minimized.
My initial assumption is that the |
1f8572d
to
80a4604
Compare
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
The failure's pretty reproducible, so I assume there's some cross-talk:
What's awesome is that I can reproduce it locally, and I can also reproduce it locally if I revert this changeset. Not sure how to debug that one. |
This comment has been minimized.
This comment has been minimized.
@Ladicek very kindly debugged this for me, since the problem test has always failed for me locally. He pointed out that I was mixing a One solution would be to split the tests out into their own modules but I was reluctant to go super-granular with the modules, so I've applied the second fix @Ladicek suggested, which is just to take That fixes CI, so I will squash. |
I also slightly clarified the wording on the docs. Co-Authored-By: Ladislav Thon <[email protected]>
cef8e65
to
6ef81f9
Compare
Status for workflow
|
Status for workflow
|
Thanks @holly-cummins and @Ladicek ! |
Good news! This test is already failing! I mean, it's bad news that it's failing, but it's good news because it's failing on my classloading-rewrite branch, which means the coverage gap was real, and a regression got caught before making it to the field. |
Our test coverage for
@QuarkusMain
is all in thepicocli-native
project. Although it covers more complex scenarios relating to picocli commands, it doesn't cover the specific scenario in https://quarkus.io/guides/command-mode-reference#mocking. Since it's documented, we want it to keep working. #28997I've slightly updated the wording in the docs, since I needed a bit of help to understand the intent of the example test, and I've added an integration test which exercises the scenario of using a test profile to adjust injected beans.