Cleanup and optimize InvocationContext implementation #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanne
reviewed
Oct 16, 2019
...nt-projects/arc/runtime/src/main/java/io/quarkus/arc/LifecycleCallbackInvocationContext.java
Outdated
Show resolved
Hide resolved
Sanne
reviewed
Oct 16, 2019
...nt-projects/arc/runtime/src/main/java/io/quarkus/arc/LifecycleCallbackInvocationContext.java
Outdated
Show resolved
Hide resolved
Sanne
reviewed
Oct 16, 2019
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/AbstractInvocationContext.java
Show resolved
Hide resolved
Sanne
reviewed
Oct 16, 2019
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/AbstractInvocationContext.java
Outdated
Show resolved
Hide resolved
|
I've added some comments hoping they could be useful, but this is not my area of expertise so I'll leave it for others to do a real review. Feel free to ignore me, I'm mostly trying to understand this :) |
|
Thanks @Sanne! |
manovotn
reviewed
Oct 16, 2019
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/AbstractInvocationContext.java
Outdated
Show resolved
Hide resolved
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/InvocationContexts.java
Outdated
Show resolved
Hide resolved
...nt-projects/arc/runtime/src/main/java/io/quarkus/arc/LifecycleCallbackInvocationContext.java
Outdated
Show resolved
Hide resolved
manovotn
reviewed
Oct 16, 2019
...nt-projects/arc/runtime/src/main/java/io/quarkus/arc/LifecycleCallbackInvocationContext.java
Outdated
Show resolved
Hide resolved
- cache interceptor bindings in intercepted subclasses - resolves quarkusio#4552
manovotn
approved these changes
Oct 18, 2019
|
The failing test is very likely unrelated: #4626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple (and naive) microbenchmark shows that we can get almost 5x bigger throughput compared to 0.24.0. Also the number of allocations should be significantly reduced for each intercepted method invocation.