WIP Reintroduces Gradle ITs in main tree #4579

gastaldi · 2019-10-15T14:33:45Z

Fixes #3174 and closes #2783 and closes #1623

gsmet

Thanks @gastaldi ! I added a small question inline.

integration-tests/gradle/build.gradle

gastaldi · 2019-10-15T15:45:06Z

The native tests are not really being invoked. Still investigating

integration-tests/gradle/pom.xml

geoand · 2019-10-16T08:12:48Z

Looking into this I realize there is a problem with the generated gradle projects. I'll open a PR soon

geoand · 2019-10-16T08:23:36Z

@gastaldi to get the tests running, you'll need to include something like: #4600

geoand · 2019-10-16T08:54:46Z

Also there seems to be a general issue with the integration tests and gradle that I am looking into.

geoand · 2019-10-16T12:46:47Z

I have updated #4600 to get tests working in gradle projects

gsmet · 2019-10-17T18:43:24Z

So I suppose this one should be rebased?

geoand · 2019-10-17T18:49:38Z

With all the Gradle changes that have gone in, I would say definitely

gastaldi · 2019-10-17T18:55:42Z

I'm getting the following error after rebasing, any clues?

➜  gradle git:(revert-rm-gradle-it_PR-2214) ✗ gradle build -Pversion=999-SNAPSHOT --stacktrace

> Task :quarkusBuild FAILED
building quarkus runner

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':quarkusBuild'.
> Failed to build a runnable JAR

* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':quarkusBuild'.
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$3.accept(ExecuteActionsTaskExecuter.java:166)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$3.accept(ExecuteActionsTaskExecuter.java:163)
        at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:191)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:156)
        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:62)
        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:108)
        at org.gradle.api.internal.tasks.execution.ResolveBeforeExecutionOutputsTaskExecuter.execute(ResolveBeforeExecutionOutputsTaskExecuter.java:67)
        at org.gradle.api.internal.tasks.execution.ResolveAfterPreviousExecutionStateTaskExecuter.execute(ResolveAfterPreviousExecutionStateTaskExecuter.java:46)
        at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:94)
        at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
        at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:95)
        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:416)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:406)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:102)
        at org.gradle.internal.operations.DelegatingBuildOperationExecutor.call(DelegatingBuildOperationExecutor.java:36)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
        at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:43)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:355)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:343)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:336)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:322)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker$1.execute(DefaultPlanExecutor.java:134)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker$1.execute(DefaultPlanExecutor.java:129)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:202)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.executeNextNode(DefaultPlanExecutor.java:193)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:129)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
Caused by: org.gradle.api.GradleException: Failed to build a runnable JAR
        at io.quarkus.gradle.tasks.QuarkusBuild.buildQuarkus(QuarkusBuild.java:185)
        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:103)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:49)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:42)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:28)
        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:717)
        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:684)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$5.run(ExecuteActionsTaskExecuter.java:476)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:402)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:394)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:165)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:250)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:158)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:92)
        at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:461)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:444)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.access$200(ExecuteActionsTaskExecuter.java:93)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$TaskExecution.execute(ExecuteActionsTaskExecuter.java:237)
        at org.gradle.internal.execution.steps.ExecuteStep.lambda$execute$1(ExecuteStep.java:33)
        at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:33)
        at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:26)
        at org.gradle.internal.execution.steps.CleanupOutputsStep.execute(CleanupOutputsStep.java:58)
        at org.gradle.internal.execution.steps.CleanupOutputsStep.execute(CleanupOutputsStep.java:35)
        at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:48)
        at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:33)
        at org.gradle.internal.execution.steps.CancelExecutionStep.execute(CancelExecutionStep.java:39)
        at org.gradle.internal.execution.steps.TimeoutStep.executeWithoutTimeout(TimeoutStep.java:73)
        at org.gradle.internal.execution.steps.TimeoutStep.execute(TimeoutStep.java:54)
        at org.gradle.internal.execution.steps.CatchExceptionStep.execute(CatchExceptionStep.java:35)
        at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:51)
        at org.gradle.internal.execution.steps.SnapshotOutputsStep.execute(SnapshotOutputsStep.java:45)
        at org.gradle.internal.execution.steps.SnapshotOutputsStep.execute(SnapshotOutputsStep.java:31)
        at org.gradle.internal.execution.steps.CacheStep.executeWithoutCache(CacheStep.java:208)
        at org.gradle.internal.execution.steps.CacheStep.execute(CacheStep.java:70)
        at org.gradle.internal.execution.steps.CacheStep.execute(CacheStep.java:45)
        at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:49)
        at org.gradle.internal.execution.steps.StoreSnapshotsStep.execute(StoreSnapshotsStep.java:43)
        at org.gradle.internal.execution.steps.StoreSnapshotsStep.execute(StoreSnapshotsStep.java:32)
        at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:38)
        at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:24)
        at org.gradle.internal.execution.steps.SkipUpToDateStep.executeBecause(SkipUpToDateStep.java:96)
        at org.gradle.internal.execution.steps.SkipUpToDateStep.lambda$execute$0(SkipUpToDateStep.java:89)
        at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:54)
        at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:38)
        at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:76)
        at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:37)
        at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:36)
        at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:26)
        at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:90)
        at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:48)
        at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:69)
        at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:47)
        at org.gradle.internal.execution.impl.DefaultWorkExecutor.execute(DefaultWorkExecutor.java:33)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:140)
        ... 34 more
Caused by: io.quarkus.creator.AppCreatorException: Failed to build a runner jar
        at io.quarkus.creator.phase.runnerjar.RunnerJarPhase.provideOutcome(RunnerJarPhase.java:216)
        at io.quarkus.creator.phase.runnerjar.RunnerJarPhase.provideOutcome(RunnerJarPhase.java:59)
        at io.quarkus.creator.outcome.OutcomeResolver.resolve(OutcomeResolver.java:31)
        at io.quarkus.creator.AppCreator.resolveOutcome(AppCreator.java:239)
        at io.quarkus.gradle.tasks.QuarkusBuild.buildQuarkus(QuarkusBuild.java:182)
        ... 88 more
Caused by: io.quarkus.creator.AppCreatorException: Failed to augment application classes
        at io.quarkus.creator.phase.augment.AugmentPhase.doProcess(AugmentPhase.java:427)
        at io.quarkus.creator.phase.augment.AugmentPhase.provideOutcome(AugmentPhase.java:251)
        at io.quarkus.creator.phase.augment.AugmentPhase.provideOutcome(AugmentPhase.java:72)
        at io.quarkus.creator.outcome.OutcomeResolver.resolve(OutcomeResolver.java:31)
        at io.quarkus.creator.AppCreator.resolveOutcome(AppCreator.java:239)
        at io.quarkus.creator.phase.runnerjar.RunnerJarPhase.provideOutcome(RunnerJarPhase.java:214)
        ... 92 more
Caused by: java.io.FileNotFoundException: JAR entry META-INF/quarkus-config-roots.list not found in /home/ggastald/.m2/repository/io/quarkus/quarkus-core/999-SNAPSHOT/quarkus-core-999-SNAPSHOT.jar
        at io.quarkus.deployment.util.ServiceUtil.classNamesNamedIn(ServiceUtil.java:42)
        at io.quarkus.deployment.util.ServiceUtil.classesNamedIn(ServiceUtil.java:29)
        at io.quarkus.deployment.ExtensionLoader.loadStepsFrom(ExtensionLoader.java:177)
        at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:73)
        at io.quarkus.creator.phase.augment.AugmentPhase.doProcess(AugmentPhase.java:347)
        ... 97 more


* Get more help at https://help.gradle.org

BUILD FAILED in 2s
4 actionable tasks: 1 executed, 3 up-to-date

geoand · 2019-10-17T18:58:39Z

I've never seen that one before...

gsmet · 2019-10-21T11:04:17Z

@gastaldi CI is failing, can you have a look?

gastaldi · 2019-10-25T14:28:20Z

Depends on #4870

integration-tests/gradle/build.gradle

gastaldi · 2019-10-25T21:12:47Z

Finally green! However, the Build error in Windows seems unrelated. Flaky tests?

geoand · 2019-10-26T04:05:20Z

I restarted the Windows test, let's see...

gastaldi · 2019-10-26T11:27:09Z

Looks like it's green now. Thanks for restarting the build

geoand

🎉

geoand · 2019-10-26T11:28:35Z

@gsmet OK to merge?

geoand · 2019-10-27T14:49:55Z

This would be great to have. I could really use some gradle integration tests for a ClassLoader change I want to explore.

gastaldi · 2019-10-28T20:03:20Z

Requires #4937

gsmet · 2019-10-29T00:47:01Z

I don't know exactly what happened between all green and all red but we now have this sort of failures that look related:

[INFO] --- exec-maven-plugin:1.6.0:exec (gradle-test) @ quarkus-integration-test-gradle-plugin ---
[ERROR] Command execution failed.
java.io.IOException: Cannot run program "/home/vsts/work/1/s/integration-tests/gradle/target/gradlew" (in directory "/home/vsts/work/1/s/integration-tests/gradle/target"): error=2, No such file or directory
    at java.lang.ProcessBuilder.start (ProcessBuilder.java:1128)
    at java.lang.ProcessBuilder.start (ProcessBuilder.java:1071)
    at java.lang.Runtime.exec (Runtime.java:589)
    at org.apache.commons.exec.launcher.Java13CommandLauncher.exec (Java13CommandLauncher.java:61)
    at org.apache.commons.exec.DefaultExecutor.launch (DefaultExecutor.java:279)
    at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:336)
    at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:804)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:751)
    at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:313)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:567)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: java.io.IOException: error=2, No such file or directory
    at java.lang.ProcessImpl.forkAndExec (Native Method)
    at java.lang.ProcessImpl.<init> (ProcessImpl.java:340)
    at java.lang.ProcessImpl.start (ProcessImpl.java:271)
    at java.lang.ProcessBuilder.start (ProcessBuilder.java:1107)
    at java.lang.ProcessBuilder.start (ProcessBuilder.java:1071)
    at java.lang.Runtime.exec (Runtime.java:589)
    at org.apache.commons.exec.launcher.Java13CommandLauncher.exec (Java13CommandLauncher.java:61)
    at org.apache.commons.exec.DefaultExecutor.launch (DefaultExecutor.java:279)
    at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:336)
    at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:804)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:751)
    at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:313)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:567)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

gastaldi · 2019-10-29T02:33:47Z

That's because the quakus-gradle-plugin cannot be resolved from the quarkus-maven-plugin because it uses a different local repository and that local repository (-Dmaven.repo.local from MAVEN_OPTS) is probably not being set when the Gradle plugin is invoked.

I am still investigating on how to solve that, but it probably won't be in time for 0.27.0

geoand · 2019-10-31T08:04:41Z

@gastaldi want to give it one more attempt with a rebase onto the latest master?

Comment has been addressed

Fixes #3174 and closes #2783 and #1623

gastaldi · 2019-11-13T20:12:44Z

Integration tests for the Gradle plugin should be executed using Gradle as the build tool, therefore it's recommended to be in the same project as the Gradle plugin lives. Closing this PR now.

gastaldi requested a review from gsmet October 15, 2019 14:34

gastaldi changed the title ~~Reintroduces Gradle ITs in main tree~~ WIP: Reintroduces Gradle ITs in main tree Oct 15, 2019

gsmet previously requested changes Oct 15, 2019

View reviewed changes

integration-tests/gradle/build.gradle Outdated Show resolved Hide resolved

gastaldi changed the title ~~WIP: Reintroduces Gradle ITs in main tree~~ Reintroduces Gradle ITs in main tree Oct 15, 2019

gastaldi added the coding-in-progress label Oct 15, 2019

geoand reviewed Oct 16, 2019

View reviewed changes

integration-tests/gradle/pom.xml Outdated Show resolved Hide resolved

gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Oct 17, 2019

gastaldi changed the title ~~Reintroduces Gradle ITs in main tree~~ [WIP] - Reintroduces Gradle ITs in main tree Oct 18, 2019

gsmet added this to the 0.27.0 milestone Oct 21, 2019

gastaldi removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Oct 23, 2019

geoand reviewed Oct 25, 2019

View reviewed changes

integration-tests/gradle/build.gradle Outdated Show resolved Hide resolved

gastaldi changed the title ~~[WIP] - Reintroduces Gradle ITs in main tree~~ Reintroduces Gradle ITs in main tree Oct 25, 2019

gastaldi added area/gradle Gradle triage/test-case-failing and removed coding-in-progress labels Oct 25, 2019

gastaldi mentioned this pull request Oct 26, 2019

gradle testNative ignores *IT tests #4881

Closed

geoand approved these changes Oct 26, 2019

View reviewed changes

geoand mentioned this pull request Oct 27, 2019

Don't delegate to parent CL for "leaking" dependencies from build system #4905

Closed

geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 28, 2019

gastaldi removed this from the 0.27.0 milestone Oct 29, 2019

gastaldi changed the title ~~Reintroduces Gradle ITs in main tree~~ WIP Reintroduces Gradle ITs in main tree Oct 29, 2019

gastaldi removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 29, 2019

geoand mentioned this pull request Oct 31, 2019

revert gradle-it removal (#2214), with fix #2783

Closed

gastaldi added 4 commits October 31, 2019 10:13

Reintroduces Gradle ITs in main tree

3e0c494

Fixes #3174 and closes #2783 and #1623

Include MAVEN_OPTS in the Gradle process

800a73b

CreateProject is now created in a subdirectory

9e35078

-DskipTests is now honored

c27dc23

geoand mentioned this pull request Nov 8, 2019

Update Kotlin and Scala gradle templates to match Java template #5311

Merged

gastaldi closed this Nov 13, 2019

gastaldi deleted the revert-rm-gradle-it_PR-2214 branch November 13, 2019 20:12

gastaldi added the triage/invalid This doesn't seem right label Nov 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP Reintroduces Gradle ITs in main tree #4579

WIP Reintroduces Gradle ITs in main tree #4579

gastaldi commented Oct 15, 2019 •

edited

Loading

gsmet left a comment

gastaldi commented Oct 15, 2019

geoand commented Oct 16, 2019

geoand commented Oct 16, 2019

geoand commented Oct 16, 2019

geoand commented Oct 16, 2019

gsmet commented Oct 17, 2019

geoand commented Oct 17, 2019

gastaldi commented Oct 17, 2019

geoand commented Oct 17, 2019

gsmet commented Oct 21, 2019

gastaldi commented Oct 25, 2019

gastaldi commented Oct 25, 2019

geoand commented Oct 26, 2019

gastaldi commented Oct 26, 2019

geoand left a comment

geoand commented Oct 26, 2019

geoand commented Oct 27, 2019

gastaldi commented Oct 28, 2019

gsmet commented Oct 29, 2019

gastaldi commented Oct 29, 2019

geoand commented Oct 31, 2019

gastaldi commented Nov 13, 2019

WIP Reintroduces Gradle ITs in main tree #4579

WIP Reintroduces Gradle ITs in main tree #4579

Conversation

gastaldi commented Oct 15, 2019 • edited Loading

gsmet left a comment

Choose a reason for hiding this comment

gastaldi commented Oct 15, 2019

geoand commented Oct 16, 2019

geoand commented Oct 16, 2019

geoand commented Oct 16, 2019

geoand commented Oct 16, 2019

gsmet commented Oct 17, 2019

geoand commented Oct 17, 2019

gastaldi commented Oct 17, 2019

geoand commented Oct 17, 2019

gsmet commented Oct 21, 2019

gastaldi commented Oct 25, 2019

gastaldi commented Oct 25, 2019

geoand commented Oct 26, 2019

gastaldi commented Oct 26, 2019

geoand left a comment

Choose a reason for hiding this comment

geoand commented Oct 26, 2019

geoand commented Oct 27, 2019

gastaldi commented Oct 28, 2019

gsmet commented Oct 29, 2019

gastaldi commented Oct 29, 2019

geoand commented Oct 31, 2019

gastaldi commented Nov 13, 2019

gastaldi commented Oct 15, 2019 •

edited

Loading