-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GraalVM 19.2.1 #4653
Update to GraalVM 19.2.1 #4653
Conversation
Seems to be a duplicate of #4639? |
I closed mine because I'm adorable :). |
The Maven artifacts are still not there. |
@cescoffier I believe you also need to update here: https://github.com/quarkusio/quarkus/blob/master/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java#L136 |
Still only a draft? Looking forward to this... |
ah ic, thanks @gsmet . Yet this was happening regularly in early days? The svm annotations rarely change, that's why we had our build system prepare to run the build with the older annotations, and yet build with the latest. In case of such a micro update that might be fine to do again? |
Yeah, tbh, at the beginning, I was expecting a quick reaction from the GraalVM team :). I always prefer to have the artifacts aligned to avoid potential weird issues. This PR needs to be modified per George's comment. But yeah, maybe let's use the old artifacts for now and update later. |
Will work on it just after my current call. |
b529a0e
to
fa84855
Compare
I've done the requested changes. |
Thanks, I'll test this locally as well with the expected VM versions. |
I'm having native compilation failures of the vault module. I'll try with the older (current) version next.. |
@Sanne what's the status for you? Were the failures related to the Docker issue? It looks good from a CI point of view. |
@gsmet I could not re-launch all native tests. It was doing fine and got quite far ahead in the process but then I had to suspend my workstation... I will resume it tomorrow, but if CI is fine with it I guess let's merge it. |
This is the update to GraalVM 19.2.1
The build won't pass until the artifacts are in maven central