Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore META-INF/quarkus-extension.json when building uberjars #4750

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 22, 2019

No description provided.

@gsmet gsmet added this to the 0.27.0 milestone Oct 22, 2019
@gsmet
Copy link
Member Author

gsmet commented Oct 22, 2019

/cc @aloubyansky @maxandersen please adjust if you change the file extension at some point.

@maxandersen
Copy link
Member

wait - educate me here - where is uber jars made ? would loose metadata access in that case...might not be an issue but just wondering where this is used ?

@gsmet
Copy link
Member Author

gsmet commented Oct 22, 2019

It's used when the users want to build an uberJar for their application. So runner.jar + all the dependencies.

Obviously, you can't get several of the same files in the jar thus the issue.

If these information are not necessary at runtime then it shouldn't be an issue. But for sure, if you need them at runtime, it's gonna be a problem.

@maxandersen
Copy link
Member

thanks for the info - looking at all the other files that gets ignored I'm sure we'll be able to survive or at least be in as good a shape as anyone wanting to look up module info or other fun metadata ;)

@geoand geoand merged commit b12dfe2 into quarkusio:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants