Remove not used extension registry plugins #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
checked i can build (without tests) so lets see what the PR completes if we want to be sure it doesn't break any other IT tests. |
|
or @aloubyansky if you can verify you agree i'm fine applying this immediately ;) |
maxandersen
force-pushed
the
removeextpluging
branch
from
ced6653 to
e12cd15
Compare
aloubyansky
approved these changes
Oct 23, 2019
aloubyansky
added
the
triage/waiting-for-ci
maxandersen
force-pushed
the
removeextpluging
branch
from
e12cd15 to
e81f3f6
Compare
|
CI isn't liking this :( |
Why: * want to improve Extension metadata and old registry plugins makes that harder. This change addreses the need by: * remove the extension plugin. * next step after is to remove the old registry platform but that is currently being used.
maxandersen
force-pushed
the
removeextpluging
branch
from
e81f3f6 to
f116e6a
Compare
my bad - removed a module but didn't remove the previous built one in .m2 cache thus my local build was running fine. pushed update that should hopefully get us further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
makes that harder.
This change addreses the need by:
currently being used.