Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jackson-databind 2.9.10.1 to fix CVE #4790

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

loicmathieu
Copy link
Contributor

This upgrade will fix these new CVE-2019-16942, CVE-2019-16943, CVE-2019-17531

Unfortunatly, this version in not in the Jackson BOM 2.9.10 and there is no patch version of BOM so we have to add an explicit dependency management to it

@gsmet
Copy link
Member

gsmet commented Oct 23, 2019

We need @cescoffier 's blessing for it as IIRC we were waiting for some Vert.x feedback.

@loicmathieu
Copy link
Contributor Author

We need @cescoffier 's blessing for it as IIRC we were waiting for some Vert.x feedback.

I think it's for 2.10 that we need Vert.x feedback. 2.9.10.1 is just a security update ...

Comment on lines 72 to 73
<!-- Fix a databing version higher that the one from the BOM for CVE vulnerabilities: CVE-2019-16942, CVE-2019-16943, CVE-2019-17531 -->
<jackson-databind.version>2.9.10.1</jackson-databind.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding another property and dependency is not need, the BOM is used in Quarkus, so the BOM should be updated.

The Jackson BOM version corresponding to this fix is 2.9.10.20191020 so is enough to change

<jackson.version>2.9.10.20191020</jackson.version>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I search on maven if there was an updated BOM and missed that one.
PR updated

@loicmathieu loicmathieu force-pushed the fix/jackson-databind-cve branch from da7ba39 to 6e1634a Compare October 23, 2019 15:05
@gsmet
Copy link
Member

gsmet commented Oct 23, 2019

I think it's for 2.10 that we need Vert.x feedback. 2.9.10.1 is just a security update ...

Ah yes, sorry I missed that it was a 2.9. I will merge it right away. Thanks!

@gsmet gsmet merged commit 78bc0b1 into quarkusio:master Oct 23, 2019
@gsmet gsmet added this to the 0.27.0 milestone Oct 23, 2019
@loicmathieu loicmathieu deleted the fix/jackson-databind-cve branch October 24, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants