Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken gradle buildNative #4807

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Fix broken gradle buildNative #4807

merged 1 commit into from
Oct 23, 2019

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 23, 2019 •
edited
Loading

The task needs to be executed after assemble.

When build was being used that was the case which is why that one was working.

@geoand geoand requested a review from gastaldi October 23, 2019 15:16
gastaldi
gastaldi approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 23, 2019
@geoand geoand added this to the 0.27.0 milestone Oct 23, 2019
ia3andy
ia3andy approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand
Copy link
Contributor Author

geoand commented Oct 23, 2019

Need to look at the CI failure

@geoand
Fix broken gradle buildNative
47a5b64 
The task needs to be executed after assemble
@geoand geoand force-pushed the gradle-fix-buildNative branch from 2cbb972 to 47a5b64 Compare October 23, 2019 20:58
@stuartwdouglas stuartwdouglas merged commit 7e35142 into quarkusio:master Oct 23, 2019
@geoand geoand deleted the gradle-fix-buildNative branch October 24, 2019 05:48
@ia3andy ia3andy mentioned this pull request Oct 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@gastaldi gastaldi gastaldi approved these changes

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
5 participants
@geoand @gastaldi @stuartwdouglas @gsmet @ia3andy