RESTEasy standalone - handle @ApplicationPath value correctly #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
requested review from
patriot1burke,
cescoffier and
stuartwdouglas
and removed request for
patriot1burke and
cescoffier
patriot1burke
previously requested changes
Oct 23, 2019
|
LGTM except the lack of tests |
|
Good point with the tests. I'll add some. |
- application path value does not have to start with a slash - resource should not be served from both the root and the app path - resolves quarkusio#4787
|
Tests added... |
|
@patriot1burke Pls could you re-review this PR again? |
stuartwdouglas
approved these changes
Oct 24, 2019
gsmet
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPL NOTE: We register the delegating handler in the default route (matches
HttpBuildTimeConfig.path) for a JAX-RS root resource path of a default value/. However, for any other value we do register the handler in a special route that matches the root resource path. In fact, we register two routes that share the same handler. For example, for the JAX-RS root resource path/foowe register two routes, first matches/foo(exact match) and the second one matches/foo/*. And the reason is that otherwise the resources would be served from both the root and the app path - see the issue description for an example.