Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elytron properties help #4818

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 23, 2019

No rocket science but let's get these properties right.

@gsmet gsmet added this to the 0.27.0 milestone Oct 23, 2019
@gwenneg
Copy link
Member

gwenneg commented Oct 23, 2019

I know it's not part of your changes, but do we really need all those getters and setters? :) If yes, shouldn't the plainText field also have its getter and setter (and be part of the toString method)?

@gsmet
Copy link
Member Author

gsmet commented Oct 23, 2019

I know it's not part of your changes, but do we really need all those getters and setters? :) If yes, shouldn't the plainText field also have its getter and setter (and be part of the toString method)?

Yeah, let's try to clean this up.

@gsmet
Copy link
Member Author

gsmet commented Oct 23, 2019

@gwenneg done.

@gsmet gsmet force-pushed the fix-properties-help branch from aff10a0 to 163f0e5 Compare October 23, 2019 21:26
@gwenneg gwenneg merged commit 316ea83 into quarkusio:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants