-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration-tests - Use the right version of quarkus-maven-plugin in the native profile #4843
Conversation
Could you do a quick sanity check that it’s not an issue with some other ITs? And that our Pom templates generating the projet poms are Ok? They are ftl files. |
hello @gsmet I found quite a few. see #4836 (comment) |
I did some manual checks and found a bunch of them in the integration-tests that were missing the version. I've updated this PR to include them. I was really hoping we could set this As for the ftl files which we use to generate some of these pom.xml files, I had a look at them in the |
There will be a parent pom eventually AFAIK, but not soon. |
Hello @geoand, there in fact is a parent pom.xml in the |
Ah sorry, I thought you were referring to a general parent pom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a Maven issue to me but if we have at least one Maven version having this problem, we need a workaround anyway.
Thanks for working on this!
The commit here should fix the issue reported in #4836.
Ideally, I think, the parent pom.xml of the integration tests should probably dictate this in
pluginManagement
for thenative
profile too. But I couldn't get that working. Nor do I see any conclusive documentation that thepluginManagement
for profiles is supported from the parent pom.xml. So at least for now, this goes directly in thevault-app
'snative
profile in pom.xml