Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-tests - Use the right version of quarkus-maven-plugin in the native profile #4843

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

jaikiran
Copy link
Member

The commit here should fix the issue reported in #4836.

Ideally, I think, the parent pom.xml of the integration tests should probably dictate this in pluginManagement for the native profile too. But I couldn't get that working. Nor do I see any conclusive documentation that the pluginManagement for profiles is supported from the parent pom.xml. So at least for now, this goes directly in the vault-app's native profile in pom.xml

@gsmet
Copy link
Member

gsmet commented Oct 24, 2019

Could you do a quick sanity check that it’s not an issue with some other ITs? And that our Pom templates generating the projet poms are Ok? They are ftl files.

@vsevel
Copy link
Contributor

vsevel commented Oct 24, 2019

Could you do a quick sanity check that it’s not an issue with some other ITs?

hello @gsmet I found quite a few. see #4836 (comment)
can't say if sometimes they are legitimate though

@jaikiran jaikiran changed the title integration-tests/vault-app - Use the right version of quarkus-maven-plugin in the native profile integration-tests - Use the right version of quarkus-maven-plugin in the native profile Oct 24, 2019
@jaikiran
Copy link
Member Author

Could you do a quick sanity check that it’s not an issue with some other ITs?

I did some manual checks and found a bunch of them in the integration-tests that were missing the version. I've updated this PR to include them.

I was really hoping we could set this native profile in the parent pom.xml and then add pluginManagement there, just like with the default build/profile, but that isn't working for me. Maybe @aloubyansky would know if that's supported?

As for the ftl files which we use to generate some of these pom.xml files, I had a look at them in the devtools/templates and those rightly use the ${quarkus.version} for the quarkus-maven-plugin in them. So this all looks like hand generated pom.xml errors.

@geoand
Copy link
Contributor

geoand commented Oct 24, 2019

There will be a parent pom eventually AFAIK, but not soon.

@jaikiran
Copy link
Member Author

jaikiran commented Oct 24, 2019

There will be a parent pom eventually

Hello @geoand, there in fact is a parent pom.xml in the integration-tests directory. It's just that the plugin versions within a specific profile of child projects don't seem to be managable through top level pluginManagement in the parent pom.xml nor through adding a specific native profile in the parent pom.xml

@geoand
Copy link
Contributor

geoand commented Oct 24, 2019

Ah sorry, I thought you were referring to a general parent pom.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a Maven issue to me but if we have at least one Maven version having this problem, we need a workaround anyway.

Thanks for working on this!

@gsmet gsmet merged commit da98814 into quarkusio:master Oct 24, 2019
@gsmet gsmet added this to the 0.27.0 milestone Oct 24, 2019
@jaikiran jaikiran deleted the qk-4836 branch October 25, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants