Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add categories binding to extension json descriptors #4936

Closed
wants to merge 2 commits into from
Closed

Add categories binding to extension json descriptors #4936

wants to merge 2 commits into from

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Oct 28, 2019 •
edited
Loading

@ia3andy ia3andy changed the title Add categories binding to extension json descriptors [wip] Add categories binding to extension json descriptors Oct 28, 2019
@ia3andy ia3andy changed the title [wip] Add categories binding to extension json descriptors Add categories binding to extension json descriptors Oct 28, 2019
@maxandersen
Copy link
Member

I’ll merge this in tonight.

maxandersen
maxandersen approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - not a fan of the renames but afte rmanually checking and doing 2 rebuilds it has no impacts so merging it in to clean up.

@maxandersen
Copy link
Member

was rebased and merged to master.

@gsmet gsmet added this to the 0.27.0 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxandersen maxandersen maxandersen approved these changes

@aloubyansky aloubyansky Awaiting requested review from aloubyansky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ia3andy @maxandersen @gsmet