HTTP Authorization Refactor #4979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stuartwdouglas It all looks good, I'd only consider making it obvious that context is meant for the blocking calls (or even move it out of the signature if it is easy enough to do), as per this comment, unless you plan to add more operations to |
|
Eventually it may contain more context info, so I would rather leave it to future proof. |
|
@stuartwdouglas OK, that makes sense. So may be it is worth pushing the doc about the blocking calls from the class itself to the method which does the blocking call ? |
pedroigor
approved these changes
Oct 29, 2019
stuartwdouglas
force-pushed
the
webxml-authen-partial
branch
from
4e2ae95 to
5b1d563
Compare
|
Quarkus HTTP Beta3 has hit Central so I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #4956 that does not need the new quarkus-http release. If the other artifact is not published in time then ideally this one will go in as it fixes some problems (such as blocking ops on the IO thread)