Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove private field injection from within our own extensions. #5066

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Remove private field injection from within our own extensions. #5066

merged 1 commit into from
Oct 31, 2019

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Oct 31, 2019 •
edited
Loading

These can lead to debug log warning about unrecommended usage of private fields.

loicmathieu
loicmathieu approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand
Copy link
Contributor

geoand commented Oct 31, 2019

@manovotn can you also change QuarkusObjectMapperContextResolver please?

@manovotn manovotn force-pushed the removePrivateFields branch from ffc5280 to c395684 Compare October 31, 2019 09:02
@manovotn
Copy link
Contributor Author

QuarkusObjectMapperContextResolver

Sure thing, done!

geoand
geoand approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@geoand geoand added this to the 0.28.0 milestone Oct 31, 2019
@loicmathieu
Copy link
Contributor

@manovotn there is also one in quarkus Vert.x

2019-10-31 10:36:30,600 INFO  [io.qua.arc.pro.BeanProcessor] (build-22) Found unrecommended usage of private members (use package-private instead) in application beans:
	- Bean constructor void <init>() on io.quarkus.vertx.CodecRegistrationTest$EventBusConsumers

@manovotn
Copy link
Contributor Author

@loicmathieu I'll add it here as well, but that's just a test class.
I know there are even some tests that have this deliberately (mostly in arc) but I don't think we care about this much in tests.

@manovotn manovotn force-pushed the removePrivateFields branch from c395684 to 3baff96 Compare October 31, 2019 10:39
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 31, 2019
@gsmet gsmet merged commit b23d288 into quarkusio:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@loicmathieu loicmathieu loicmathieu approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manovotn @geoand @loicmathieu @gsmet