Add resteasy capability #5142
Add resteasy capability #5142
Conversation
|
I'm not 100% sure about this implementation as RESTEasy itself relies on capabilities to enable/disable some behaviors. |
| @@ -56,7 +56,7 @@ public ResteasyStandaloneBuildItem(String deploymentRootPath) { | |||
|
|
|||
| } | |||
|
|
|||
| @BuildStep() | |||
| @BuildStep(providesCapabilities = Capabilities.RESTEASY) | |||
There was a problem hiding this comment.
Is there any specific reason that both this one and the providesCapabilities on build are needed?
There was a problem hiding this comment.
In fact no, I've annotated both as both the build step are supposed to provide a resteasy's FeatureBuildItem so I've replicated the behavior to the related BuildStep annotation.
My first tough was to add a BuildProducer<CapabilityBuildItem> to both the methods and conditionally add the capability but then I noticed that one of the two builder step are also leveraging capabilities so adding a build producer could trigger a cycle.
An option would be to add an additional BuildItem to signal that resteasy is in use and add the capability.
There was a problem hiding this comment.
We probably should get rid of 'providesCapabilities' and just use a normal build item for it, the reason why it is treated specially is largely for historical reasons.
|
Superseded by #5195 |
In camel-quarkus we do enable some features or behaviors according to
the presence of resteasy and as today the conditions is the presence
of the quarkus-resteasy extension (checked by lookgin at what features
are on the classpath using FeatureBuildItems).
This PR introduces a new capability "resteasy" that can be used by our
code instead of basing our conditional on extension names.