Make LaunchMode injectable #5155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenneg
reviewed
Nov 4, 2019
| @@ -110,3 +110,11 @@ When the application is stopped, the second log message is printed. | |||
|
|
|||
| As usual, the application can be packaged using `./mvnw clean package` and executed using the `-runner.jar` file. | |||
| You can also generate the native executable using `./mvnw clean package -Pnative`. | |||
|
|
|||
| == Luanch Modes | |||
There was a problem hiding this comment.
Suggested change
| == Luanch Modes | |
| == Launch Modes |
gwenneg
reviewed
Nov 4, 2019
| == Luanch Modes | ||
|
|
||
| Quarkus has 3 different launch modes, `NORMAL` (i.e. production), `DEVELOPMENT` and `TEST`. If you are running `quarkus:dev` | ||
| then the mode will be `DEVELOPMENT`, if you are running a JUnit test it will be `TEST`, otherwise it will be normal. |
There was a problem hiding this comment.
Suggested change
| then the mode will be `DEVELOPMENT`, if you are running a JUnit test it will be `TEST`, otherwise it will be normal. | |
| then the mode will be `DEVELOPMENT`, if you are running a JUnit test it will be `TEST`, otherwise it will be `NORMAL`. |
|
I added a few suggestions about the doc. |
gwenneg
added
the
triage/waiting-for-ci
jmartisk
reviewed
Nov 4, 2019
| == Launch Modes | ||
|
|
||
| Quarkus has 3 different launch modes, `NORMAL` (i.e. production), `DEVELOPMENT` and `TEST`. If you are running `quarkus:dev` | ||
| then the mode will be `DEVELOPMENT`, if you are running a JUnit test it will be `TEST`, otherwise it will be `NORMAL`. |
There was a problem hiding this comment.
Our Arquillian adapter supports TestNG and there the launch mode is TEST too, I'm not sure how much we want to discourage people from using Arquillian, but it is possible, so perhaps we shouldn't narrow this description to just JUnit?
There was a problem hiding this comment.
At the moment we only support Arquillian for the MP TCK, this is not something we document for end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589