Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use %n for new line in case of String.format #5168

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Use %n for new line in case of String.format #5168

merged 1 commit into from
Nov 5, 2019

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Nov 4, 2019

Use %n for new line in case of String.format

aguibert
aguibert approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@aguibert aguibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

machi1990
machi1990 approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rsvoboda
Copy link
Member Author

rsvoboda commented Nov 5, 2019

@gsmet change for BeanInfo reverted

@gsmet gsmet added this to the 0.29.0 milestone Nov 5, 2019
@gsmet gsmet merged commit 1c6d3aa into quarkusio:master Nov 5, 2019
@gsmet
Copy link
Member

gsmet commented Nov 5, 2019

Thanks!

@rsvoboda rsvoboda deleted the String.format.new.line branch March 4, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@aguibert aguibert aguibert approved these changes

@machi1990 machi1990 machi1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@rsvoboda @gsmet @aguibert @machi1990