Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #5214 #5218

Merged
merged 3 commits into from
Nov 6, 2019
Merged

Fix for #5214 #5218

merged 3 commits into from
Nov 6, 2019

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Nov 5, 2019

Replace $ with . in loaded class names

Replace $ with . in loaded class names
@gsmet
Copy link
Member

gsmet commented Nov 5, 2019

@FroMage could you push the updated adoc to the website? This way, it's mostly fixed already.

Thanks!

@gsmet gsmet added this to the 0.29.0 milestone Nov 5, 2019
@FroMage
Copy link
Member Author

FroMage commented Nov 5, 2019

Well, it looks like 0849187 made the table non-searchable, so I want to understand things before rushing this out. ATM my table is not searchable.

@FroMage
Copy link
Member Author

FroMage commented Nov 5, 2019

Ah, I need to do a full build, probably. But I don't understand why some tables are not searchable anymore. Won't it make them non-searchable on each guide?

@FroMage
Copy link
Member Author

FroMage commented Nov 5, 2019

OK this is ready to be merged. Result is at quarkusio/quarkusio.github.io#344 for website.

@gsmet gsmet merged commit f3447e5 into quarkusio:master Nov 6, 2019
@gsmet gsmet removed the backport? label Nov 14, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants