Complete the Hibernate ORM guide, clarify the limitations #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Nov 6, 2019
| Connection pool:: | ||
| Don't need to choose one either. Quarkus automatically includes the Agroal connection pool; | ||
| just configure your datasource as in the above examples and it will setup Hibernate ORM to use Agroal. | ||
| More details about this connection pool can be found in link:datasource-guide.html[Quarkus - Datasources]. |
There was a problem hiding this comment.
This URL is outdated, it should point to: link:/datasource.html (without -guide)
There is a redirect so it's no biggie but better get this straight.
There was a problem hiding this comment.
ah thanks! well, without the .html too :)
There was a problem hiding this comment.
Yeah, I will make a pass on all the guides to remove the .html. That's why I didn't mention it.
|
@gsmet applied rebased, push forced. I stripped all .html also from a couple other cross-guide links this had. |
gsmet
added
the
triage/waiting-for-ci
gsmet
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long overdue, finally clarifying the limitations we still have.