Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the tooling resolve the latest version of the universe #5268

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Make the tooling resolve the latest version of the universe #5268

merged 1 commit into from
Nov 14, 2019

Conversation

aloubyansky
Copy link
Member

...by default and fall back to the bundled quarkus-bom in offline mode

@stuartwdouglas
Copy link
Member

The failure looks related

@aloubyansky aloubyansky force-pushed the resolve-latest-universe branch 2 times, most recently from 1e2d2c9 to 7e451ff Compare November 7, 2019 14:25
@maxandersen
Copy link
Member

trying to run this now (waiting on build ;)

Am I right in seeing that -DplatformVersion= actually supports taking a maven version expression ? which then translates into actual platformVersion actually being resolved ?

@maxandersen
Copy link
Member

so the feature seem to work but I didn't find a way to specify it shouldn't try resolve anything nor control the version range. Is that not supposed to be available ?

@aloubyansky aloubyansky force-pushed the resolve-latest-universe branch 2 times, most recently from 602b003 to dc86e80 Compare November 12, 2019 10:59
@maxandersen maxandersen added this to the 1.0.0.Final milestone Nov 13, 2019
@maxandersen
Copy link
Member

This looks good! Still testing out a bit for edge cases - get that reported later today.

Would love to see others use this though just to increase our confidence in it - @gastaldi and @geoand could you try it out ?

@geoand
Copy link
Contributor

geoand commented Nov 13, 2019

I think the PR needs a rebase onto the latest master to pick up some CI fixes

@aloubyansky aloubyansky force-pushed the resolve-latest-universe branch 2 times, most recently from ab75848 to b5cc0fd Compare November 13, 2019 14:06
@cescoffier
Copy link
Member

Are we good to go on this one?

@gastaldi
Copy link
Contributor

gastaldi commented Nov 13, 2019 •
edited
Loading

CI didn't trigger the tests yet

@aloubyansky @maxandersen
Make the create project mojo resolve the latest version of the univer…
6474bee 
…se by default and fall back to the bundled quarkus-bom in offline mode
@maxandersen maxandersen force-pushed the resolve-latest-universe branch from b5cc0fd to 6474bee Compare November 13, 2019 21:13
@maxandersen
Copy link
Member

force pushed after rebase with master to trigger CI

@maxandersen maxandersen self-requested a review November 13, 2019 23:08
maxandersen
maxandersen approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and @geoand verified it work for him too. waiting just for CI to finish.

@aloubyansky aloubyansky merged commit b43df0e into quarkusio:master Nov 14, 2019
@gsmet gsmet removed the backport? label Nov 14, 2019
@gsmet gsmet modified the milestones: 1.0.0.Final, 1.1.0 Nov 14, 2019
@gsmet
Copy link
Member

gsmet commented Nov 14, 2019

I unbackported it as it broke my build.

@gsmet gsmet removed the backport? label Nov 18, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi left review comments

@maxandersen maxandersen maxandersen approved these changes

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0.CR2
Development

Successfully merging this pull request may close these issues.
7 participants
@aloubyansky @stuartwdouglas @maxandersen @geoand @cescoffier @gastaldi @gsmet