Fix the application-type property in the oidc web authentication guide #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
reviewed
Nov 13, 2019
| @@ -65,11 +65,11 @@ The OpenID Connect extension allows you to define the configuration using the `a | |||
| ---- | |||
| quarkus.oidc.auth-server-url=http://localhost:8180/auth/realms/quarkus | |||
| quarkus.oidc.client-id=frontend | |||
| quarkus.oidc.client-type=web-app | |||
| quarkus.oidc.application-type=web-app | |||
There was a problem hiding this comment.
Was it a typo in the doc or is it related to some recent code changes?
There was a problem hiding this comment.
It was something we discussed with Pedro, client-type was in the PR only but application-type was what made it to the master
|
I've added a comment, just to be sure it's not a breaking change that needs to be tracked. |
|
@cescoffier sure, it probably made it to the docs while we were still discussing PR, so it is OK |
pedroigor
approved these changes
Nov 13, 2019
rsvoboda
approved these changes
Nov 13, 2019
|
So are we good to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.